andyburke/node-devents
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Supports options.db to select redis db #2

Open
hyjin wants to merge 2 commits from hyjin/master into master
pull from: hyjin/master
merge into: andyburke:master
Conversation 2 Commits 2 Files changed 1 +9 -1
hyjin commented 2014-02-18 19:11:36 -08:00 (Migrated from github.com)
Copy link

Hi, this change enables selecting db with options.db.

For example,

var emitter = new devents.EventEmitter({
    host: 'machine1.company.com',
    port: 6379,
    db: 1
});
Hi, this change enables selecting db with `options.db`. For example, ``` js var emitter = new devents.EventEmitter({ host: 'machine1.company.com', port: 6379, db: 1 }); ```
andyburke commented 2014-02-18 23:11:21 -08:00 (Migrated from github.com)
Copy link

I'll accept this PR after a couple of cosmetic changes to conform to the rest of the code style:

  1. Spaces should be used with parens
  2. Braces for if statements should be on their own line

Example:

if ( condition )
{
    someFunction( someArgument );
}
I'll accept this PR after a couple of cosmetic changes to conform to the rest of the code style: 1) Spaces should be used with parens 2) Braces for if statements should be on their own line Example: ``` javascript if ( condition ) { someFunction( someArgument ); } ```
hyjin commented 2014-02-19 14:22:40 -08:00 (Migrated from github.com)
Copy link

@andyburke Here is update for code style. Thank you!

@andyburke Here is update for code style. Thank you!
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin hyjin/master:hyjin/master
git switch hyjin/master

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff hyjin/master
git switch hyjin/master
git rebase master
git switch master
git merge --ff-only hyjin/master
git switch hyjin/master
git rebase master
git switch master
git merge --no-ff hyjin/master
git switch master
git merge --squash hyjin/master
git switch master
git merge --ff-only hyjin/master
git switch master
git merge hyjin/master
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
andyburke/node-devents!2
No description provided.