Feature/request logging

cardoni commented

2015-01-20 04:20:42 -08:00

(Migrated from github.com)

Adds two listeners/emitters to console log all upload and url-fetching requests
- Now, should an upload or url-fetch fail, storehouse.log will contain an entry corresponding to the upload/fetch attempt
Adds timestamp to Storehouse's initial status message on startup
Changed request.files['file'] to dot notation: request.files.file
Adds some missing semi-colons
Removes some whitespace

- Adds two listeners/emitters to console log all `upload` and `url-fetching` requests - Now, should an upload or url-fetch fail, storehouse.log will contain an entry corresponding to the upload/fetch attempt - Adds timestamp to Storehouse's initial status message on startup - Changed `request.files['file']` to dot notation: `request.files.file` - Adds some missing semi-colons - Removes some whitespace Closes honeinc/node-storehouse#1

andyburke commented

2015-01-21 14:16:51 -08:00

(Migrated from github.com)

Close, couple questions/revisions:

Why are we fstatting things? Shouldn't they not exist yet?
Should bump version in package.json.
Looks like this was using the old-style brace-on-new-line code formatting. Bring in a .jsbeautifyrc from one of our more recent projects and let's reformat to that.
Bring in a .jshintrc as well so we can do those checks.

Close, couple questions/revisions: 1) Why are we fstatting things? Shouldn't they not exist yet? 2) Should bump version in package.json. 3) Looks like this was using the old-style brace-on-new-line code formatting. Bring in a .jsbeautifyrc from one of our more recent projects and let's reformat to that. 4) Bring in a .jshintrc as well so we can do those checks.

cardoni commented

2015-01-22 12:33:00 -08:00

(Migrated from github.com)

Good catch on the unused fs.stat calls that I didn't remove. (I was originally passing the uploaded-file size into the emit object and was using fs to get that. And then I realized that it's always going to be 0, of course, since the file hasn't actually been received by the app and written to the file system by that point. Forgot to remove 'em.)
Fixed. Removed these fs.stat calls in 09a52d6 Also removed unnecessary mimetype calls in 36cc7dd
Fixed. 1bd413c
Done. d7ce91c
Done. d7ce91c

Finally, I beautified storehouse, cli, and code examples in README: f38fa93

1. Good catch on the unused `fs.stat` calls that I didn't remove. (I was originally passing the uploaded-file size into the emit object and was using `fs` to get that. And then I realized that it's always going to be `0`, of course, since the file hasn't actually been received by the app and written to the file system by that point. Forgot to remove 'em.)<br>_**Fixed.** Removed these `fs.stat` calls in 09a52d6 Also removed unnecessary mimetype calls in 36cc7dd_ 2. _**Fixed.** 1bd413c_ 3. _**Done.** d7ce91c_ 4. _**Done.** d7ce91c_ Finally, I beautified storehouse, cli, and code examples in README: _f38fa93_

andyburke commented

2015-01-22 12:44:21 -08:00

(Migrated from github.com)

Looks good. I'll publish to npm. Could you then look into upgrading files-02?

cardoni commented

2015-01-22 12:56:46 -08:00

(Migrated from github.com)

Will do.

andyburke commented

2015-01-22 13:09:11 -08:00

(Migrated from github.com)

Actually, I found some in-progress changes on my local machine that clean up the code, but they also change how signatures are calculated (to make it more deterministic, based on key ordering), which means our client code will have to change.

We'll need to think about how to deploy this to files-02.

Actually, I found some in-progress changes on my local machine that clean up the code, but they also change how signatures are calculated (to make it more deterministic, based on key ordering), which means our client code will have to change. We'll need to think about how to deploy this to files-02.

andyburke commented

2015-01-22 13:09:45 -08:00

(Migrated from github.com)

I'm going to add a task to the monthly goals to get this deployed, but we'll need to talk about it and implement it next week or something.

cardoni commented

2015-01-22 13:18:04 -08:00

(Migrated from github.com)

Sounds good to me.

Rows
Columns

Feature/request logging #6