Added an ellipsis to the users nickname when they are typing. #43

Merged

tristau merged 8 commits from master into master

2012-05-13 21:52:19 -07:00

tristau commented

2012-05-13 12:31:07 -07:00

(Migrated from github.com)

I'm sending a isTyping message when the user starts typing, and an isNotTyping message when they've cleared out there message box (either deleting it or sending it). I was starting to look at maybe animating the ellipsis or doing something different (like creating a ghost message in the chat window) but figured I'd send this over to you and see if you like it.

andyburke commented

2012-05-13 12:37:18 -07:00

(Migrated from github.com)

This is close. A few things:

Seems like we should do some kind of timeout if they're not typing. So, for instance:
- When a user starts typing, send a 'startedTyping' message
- If they stop typing, start a timeout 5 seconds (10 seconds?) later to send a stoppedTyping message
- If they resume typing within the timeout, cancel the timeout that was set to send the stoppedTyping message
- If they clear the text entry, send a 'cancelledTyping' message

This would allow for something like:
- On receiving a startedTyping message, add an animating elipsis to their name
- On receiving a stoppedTyping message, have a non-animating elipsis on their name, indicating they've entered text
- On receiving a standard message OR receiving a cancelledTyping message, clear the elipsis

Indenting should be 4 spaces (no tabs) per level. It seems like there are some indenting issues that it would be nice to clean up.

This is close. A few things: 1) Seems like we should do some kind of timeout if they're not typing. So, for instance: - When a user starts typing, send a 'startedTyping' message - If they stop typing, start a timeout 5 seconds (10 seconds?) later to send a stoppedTyping message - If they resume typing within the timeout, cancel the timeout that was set to send the stoppedTyping message - If they clear the text entry, send a 'cancelledTyping' message This would allow for something like: - On receiving a startedTyping message, add an animating elipsis to their name - On receiving a stoppedTyping message, have a non-animating elipsis on their name, indicating they've entered text - On receiving a standard message OR receiving a cancelledTyping message, clear the elipsis 2) Indenting should be 4 spaces (no tabs) per level. It seems like there are some indenting issues that it would be nice to clean up.