Add currency symbol #1

New issue

Closed

opened 2020-08-21 15:29:03 -07:00 by ajmas · 3 comments

ajmas commented

2020-08-21 15:29:03 -07:00

(Migrated from github.com)

It would be useful to add the currency symbol and whether it is prefixed or suffixed.

For example:


        "iso3166": {
            "alpha2": "US",
            "alpha3": "USA",
            "independent": true,
            "name": "United States",
            "numeric": 840,
            "currency": {
                "name": "US Dollar",
                "code": "USD",
                "numeric": 840,
                "minor_unit": 2,
                "symbol": "$",
                "prefixSymbol": true
            }
        },

It would be useful to add the currency symbol and whether it is prefixed or suffixed. For example: ``` "iso3166": { "alpha2": "US", "alpha3": "USA", "independent": true, "name": "United States", "numeric": 840, "currency": { "name": "US Dollar", "code": "USD", "numeric": 840, "minor_unit": 2, "symbol": "$", "prefixSymbol": true } }, ```

👍 1

andyburke commented

2020-08-21 19:05:20 -07:00

(Migrated from github.com)

I'll gladly accept a PR with this.

ajmas commented

2020-08-22 18:47:19 -07:00

(Migrated from github.com)

Just dropping this here for reference, to start with: https://www.currencyremitapp.com/world-currency-symbols/

currency-with-symbols.xlsx

Just dropping this here for reference, to start with: https://www.currencyremitapp.com/world-currency-symbols/ [currency-with-symbols.xlsx](https://github.com/andyburke/countrydata/files/5113370/currency-with-symbols.xlsx)

ajmas commented

2020-08-22 19:36:38 -07:00

(Migrated from github.com)

I have made a PR for the symbol, but for now I haven't been to get anything for the currency symbol position.

Reading this, maybe something can be garnered from Java, but I haven't done that work:

https://getaround.tech/multi-currency-java/

or possibly:

http://cldr.unicode.org/#TOC-How-to-Use-

Though this will probably be an issue for another ticket

I have made a PR for the symbol, but for now I haven't been to get anything for the currency symbol position. Reading this, maybe something can be garnered from Java, but I haven't done that work: https://getaround.tech/multi-currency-java/ or possibly: http://cldr.unicode.org/#TOC-How-to-Use- Though this will probably be an issue for another ticket