Ability to change logging behavior #69

Merged

zlumer merged 5 commits from master into master

2017-09-12 18:47:31 -07:00

zlumer commented

2017-09-08 08:23:32 -07:00

(Migrated from github.com)

I've been using UnityHTTP for some time now, and have found one feature very helpful: the ability to change logging behavior.

This PR introduces 3 different logging behaviors: UnityLogger (prints to Unity console), ConsoleLogger (prints to System.Console) and DiscardLogger (discards logs without actually printing anything).

The loggers can be set per each request, default logger is stored in Request.Logger.

The default behavior wasn't changed, I even left some of the #defines in place to maintain 100% char-to-char backwards compatibility.

I've been using UnityHTTP for some time now, and have found one feature very helpful: the ability to change logging behavior. This PR introduces 3 different logging behaviors: `UnityLogger` (prints to Unity console), `ConsoleLogger` (prints to System.Console) and `DiscardLogger` (discards logs without actually printing anything). The loggers can be set per each request, default logger is stored in `Request.Logger`. The default behavior wasn't changed, I even left some of the #defines in place to maintain 100% char-to-char backwards compatibility.

andyburke commented

2017-09-12 18:47:38 -07:00

(Migrated from github.com)

lgtm, thanks!

zlumer commented

2017-09-18 08:12:39 -07:00

(Migrated from github.com)

Thanks for merging!